netdev - Re: [PATCH bpf] bpf: Fix the test_task_vma selftest to support output shorter than 1 kB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163857240888.22727.1341673704180599136.git-patchwork-notify@kernel.org>
Date:   Fri, 03 Dec 2021 23:00:08 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Maxim Mikityanskiy <maximmi@...dia.com>
Cc:     ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org, shuah@...nel.org,
        revest@...omium.org, davemarchevsky@...com,
        linux-kselftest@...r.kernel.org, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH bpf] bpf: Fix the test_task_vma selftest to support output
 shorter than 1 kB

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@...earbox.net>:

On Tue, 30 Nov 2021 20:18:11 +0200 you wrote:
> The test for bpf_iter_task_vma assumes that the output will be longer
> than 1 kB, as the comment above the loop says. Due to this assumption,
> the loop becomes infinite if the output turns to be shorter than 1 kB.
> The return value of read_fd_into_buffer is 0 when the end of file was
> reached, and len isn't being increased any more.
> 
> This commit adds a break on EOF to handle short output correctly. For
> the reference, this is the contents that I get when running test_progs
> under vmtest.sh, and it's shorter than 1 kB:
> 
> [...]

Here is the summary with links:
  - [bpf] bpf: Fix the test_task_vma selftest to support output shorter than 1 kB
    https://git.kernel.org/bpf/bpf-next/c/da54ab14953c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html