netdev - Re: [PATCH net-next] bond: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to active device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211202185815.27e42ac0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 2 Dec 2021 18:58:15 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>, davem@...emloft.net,
        Richard Cochran <richardcochran@...il.com>,
        Miroslav Lichvar <mlichvar@...hat.com>
Subject: Re: [PATCH net-next] bond: pass get_ts_info and SIOC[SG]HWTSTAMP
 ioctl to active device

On Fri, 3 Dec 2021 10:55:04 +0800 Hangbin Liu wrote:
> On Thu, Dec 02, 2021 at 06:59:23AM -0800, Jakub Kicinski wrote:
> > On Thu, 2 Dec 2021 11:04:40 +0800 Hangbin Liu wrote:  
> > User can point their PTP daemon at any interface. Since bond now
> > supports the uAPI the user will be blissfully unaware that their
> > configuration will break if failover happens.
> > 
> > We can't expect every user and every PTP daemon to magically understand
> > the implicit quirks of the drivers. Quirks which are not even
> > documented.  
> 
> Thanks for the explanation. I understand what you mean now.
> > 
> > What I'm saying is that we should have a new bit in the uAPI that
> > tells us that the user space can deal with unstable PHC idx and reject
> > the request forwarding in bond if that bit is not set. We have a flags
> > field in hwtstamp_config which should fit the bill. Make sense?  
> 
> Yes, this makes sense for me. I check this and try post a patch next week.

SGTM, thanks!