netdev - Re: [PATCH v2] net: broadcom: Catch the Exception

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Dec 2021 19:23:14 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>, rafal@...ecki.pl,
        bcm-kernel-feedback-list@...adcom.com, davem@...emloft.net,
        kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org, fw@...len.de
Subject: Re: [PATCH v2] net: broadcom: Catch the Exception



On 12/2/2021 7:02 PM, Jiasheng Jiang wrote:
> The return value of dma_set_coherent_mask() is not always 0.
> To catch the exception in case that dma is not support the mask.
> 
> Fixes: 9d61d138ab30 ("net: broadcom: rename BCM4908 driver & update DT binding")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>

Can you come up with a better subject, maybe:

net: bcm4908: Handle dma_set_coherent_mask error codes

or something like that?

> ---
> Changelog
> 
> v1 -> v2
> 
> * Change 1. Correct the Fixes tags.
> * Change 2. CC Florian.
> ---
>   drivers/net/ethernet/broadcom/bcm4908_enet.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> index 02a569500234..376f81796a29 100644
> --- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> @@ -708,7 +708,9 @@ static int bcm4908_enet_probe(struct platform_device *pdev)
>   
>   	enet->irq_tx = platform_get_irq_byname(pdev, "tx");
>   
> -	dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
> +	err = dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
> +	if (err)
> +		return err;
>   
>   	err = bcm4908_enet_dma_alloc(enet);
>   	if (err)
> 

-- 
Florian