netdev - Re: [PATCH net-next 02/19] lib: add tests for reference tracker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACT4Y+Y8upXSt7j4MT8jfj_s2kVKCEN0nyJmb0PQ=teiUqGVQg@mail.gmail.com>
Date:   Fri, 3 Dec 2021 08:37:45 +0100
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     kernel test robot <lkp@...el.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, kbuild-all@...ts.01.org,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 02/19] lib: add tests for reference tracker

On Thu, 2 Dec 2021 at 20:46, Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Thu, Dec 2, 2021 at 11:25 AM kernel test robot <lkp@...el.com> wrote:
> >
> > Hi Eric,
> >
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on net-next/master]
> >
> > url:    https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-add-preliminary-netdev-refcount-tracking/20211202-112353
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8057cbb8335cf6d419866737504473833e1d128a
> > config: nios2-allyesconfig (https://download.01.org/0day-ci/archive/20211203/202112030323.z9IhC2B3-lkp@intel.com/config)
> > compiler: nios2-linux-gcc (GCC) 11.2.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://github.com/0day-ci/linux/commit/5da0cdb1848fae9fb2d9d749bb94e568e2493df8
> >         git remote add linux-review https://github.com/0day-ci/linux
> >         git fetch --no-tags linux-review Eric-Dumazet/net-add-preliminary-netdev-refcount-tracking/20211202-112353
> >         git checkout 5da0cdb1848fae9fb2d9d749bb94e568e2493df8
> >         # save the config file to linux build tree
> >         mkdir build_dir
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@...el.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >    nios2-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
> > >> (.text+0x2e4): undefined reference to `save_stack_trace'
> >    (.text+0x2e4): relocation truncated to fit: R_NIOS2_CALL26 against `save_stack_trace'
> >
> > Kconfig warnings: (for reference only)
> >    WARNING: unmet direct dependencies detected for STACKTRACE
> >    Depends on STACKTRACE_SUPPORT
> >    Selected by
> >    - STACKDEPOT
> >
>
> I am not sure I understand this.
>
> Dmitry, do I need to add a depends on STACKTRACE_SUPPORT.

Humm... There is something strange about nios2 arch.

KASAN depends on ARCH_HAVE_KASAN which is not selected for nios2, so
it implicitly avoids this issue.

But I see PAGE_OWNER that also uses STACKDEPOT has "Depends on
STACKTRACE_SUPPORT".
So I guess yes.

I am not sure how Kconfig will reach if we make STACKDEPOT depend on
STACKTRACE_SUPPORT  and your config  says "select STACKDEPOT"...