[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f56cc112d886490792fcb98c8faadff6@realtek.com>
Date: Fri, 3 Dec 2021 07:57:09 +0000
From: Hayes Wang <hayeswang@...ltek.com>
To: Heiner Kallweit <hkallweit1@...il.com>,
Jakub Kicinski <kuba@...nel.org>,
David Miller <davem@...emloft.net>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [RFC PATCH 3/4] r8169: support CMAC
Heiner Kallweit <hkallweit1@...il.com>
> Sent: Tuesday, November 30, 2021 4:47 AM
> To: Hayes Wang <hayeswang@...ltek.com>; Jakub Kicinski <kuba@...nel.org>;
[...]
> > +struct rtl_dash {
> > + struct rtl8169_private *tp;
> > + struct pci_dev *pdev_cmac;
> > + void __iomem *cmac_ioaddr;
> > + struct cmac_desc *tx_desc, *rx_desc;
> > + struct page *tx_buf, *rx_buf;
> > + struct dash_tx_info tx_info[CMAC_DESC_NUM];
> > + struct tasklet_struct tl;
>
> Please see the following in include/linux/interrupt.h:
>
> /* Tasklets --- multithreaded analogue of BHs.
>
> This API is deprecated. Please consider using threaded IRQs instead:
How about replacing the tasklet with work?
It seems that the bottom half of threaded IRQ
is the work, too.
Best Regards,
Hayes
Powered by blists - more mailing lists