netdev - Re: [PATCH v2 net-next 4/5] net: mscc: ocelot: split register definitions to a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211204120027.vov363wzmk6yngbz@skbuf>
Date:   Sat, 4 Dec 2021 12:00:28 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Colin Foster <colin.foster@...advantage.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2 net-next 4/5] net: mscc: ocelot: split register
 definitions to a separate file

On Fri, Dec 03, 2021 at 05:00:49PM -0800, Colin Foster wrote:
> Move these to a separate file will allow them to be shared to other
> drivers.
> 
> Signed-off-by: Colin Foster <colin.foster@...advantage.com>
> Reported-by: kernel test robot <lkp@...el.com>

I wouldn't keep the "Reported-by" tag in this case.

> ---
>  drivers/net/ethernet/mscc/Makefile         |   3 +-
>  drivers/net/ethernet/mscc/ocelot_vsc7514.c | 520 +-------------------
>  drivers/net/ethernet/mscc/vsc7514_regs.c   | 522 +++++++++++++++++++++
>  include/soc/mscc/vsc7514_regs.h            |  27 ++
>  4 files changed, 562 insertions(+), 510 deletions(-)
>  create mode 100644 drivers/net/ethernet/mscc/vsc7514_regs.c
>  create mode 100644 include/soc/mscc/vsc7514_regs.h
> 
> diff --git a/drivers/net/ethernet/mscc/vsc7514_regs.c b/drivers/net/ethernet/mscc/vsc7514_regs.c
> new file mode 100644
> index 000000000000..b041756d1b78
> --- /dev/null
> +++ b/drivers/net/ethernet/mscc/vsc7514_regs.c
> @@ -0,0 +1,522 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Microsemi Ocelot Switch driver
> + *
> + * Copyright (c) 2017 Microsemi Corporation
> + * Copyright (c) 2021 Innovative Advantage
> + */
> +#include <soc/mscc/ocelot_vcap.h>

With Jakub's comment to add an include here (which is to resolve these
warnings):
https://patchwork.hopto.org/static/nipa/590203/12656181/build_32bit/stderr
it looks fine, so please change this and then add my:

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>