netdev - Re: [PATCH] net: wwan: iosm: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6befd600-f90c-f9fd-1196-75aa3482b1f3@linux.intel.com>
Date:   Sun, 5 Dec 2021 11:38:16 +0530
From:   "Kumar, M Chetan" <m.chetan.kumar@...ux.intel.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        Loic Poulain <loic.poulain@...aro.org>,
        Sergey Ryazanov <ryazanov.s.a@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Johannes Berg <johannes@...solutions.net>,
        Stephan Gerhold <stephan@...hold.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: wwan: iosm: select CONFIG_RELAY



On 12/4/2021 11:10 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The iosm driver started using relayfs, but is missing the Kconfig
> logic to ensure it's built into the kernel:
> 
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_create_buf_file_handler':
> iosm_ipc_trace.c:(.text+0x16): undefined reference to `relay_file_operations'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_subbuf_start_handler':
> iosm_ipc_trace.c:(.text+0x31): undefined reference to `relay_buf_full'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_ctrl_file_write':
> iosm_ipc_trace.c:(.text+0xd5): undefined reference to `relay_flush'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_port_rx':
> 
> Fixes: 00ef32565b9b ("net: wwan: iosm: device trace collection using relayfs")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: M Chetan Kumar <m.chetan.kumar@...ux.intel.com>