netdev - Re: [PATCH] net: dsa: mv88e6xxx: fix uninit-value err in mv88e6393x_serdes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211206195007.4892af4f@thinkpad>
Date:   Mon, 6 Dec 2021 19:50:07 +0100
From:   Marek Behún <kabel@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jackie Liu <liu.yun@...ux.dev>, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix uninit-value err in
 mv88e6393x_serdes_power

On Mon, 6 Dec 2021 14:45:11 +0100
Andrew Lunn <andrew@...n.ch> wrote:

> On Mon, Dec 06, 2021 at 06:13:52PM +0800, Jackie Liu wrote:
> > From: Jackie Liu <liuyun01@...inos.cn>
> > 
> > 'err' is not initialized. If the value of cmode is not in the switch case,
> > it will cause a logic error and return early.  
> 
> Same fix as: <20211206113219.17640-1-amhamza.mgc@...il.com>
> 
> At least here some analysis has been done why there is a warning.
> 
> Should we add a default?
> 
>        Andrew

indeed it should be err=0