netdev - Re: [PATCH net] devlink: fix netns refcount leak in devlink_nl_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ya245+a9vajIjYvU@unreal>
Date:   Mon, 6 Dec 2021 09:16:55 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Moshe Shemesh <moshe@...lanox.com>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net] devlink: fix netns refcount leak in
 devlink_nl_cmd_reload()

On Sun, Dec 05, 2021 at 11:28:22AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> While preparing my patch series adding netns refcount tracking,
> I spotted bugs in devlink_nl_cmd_reload()
> 
> Some error paths forgot to release a refcount on a netns.
> 
> To fix this, we can reduce the scope of get_net()/put_net()
> section around the call to devlink_reload().
> 
> Fixes: ccdf07219da6 ("devlink: Add reload action option to devlink reload command")
> Fixes: dc64cc7c6310 ("devlink: Add devlink reload limit option")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Moshe Shemesh <moshe@...lanox.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Jacob Keller <jacob.e.keller@...el.com>
> Cc: Jiri Pirko <jiri@...dia.com>
> ---
>  net/core/devlink.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>