netdev - RE: [RFC PATCH 4/4] r8169: add sysfs for dash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aaf3a1e00fca472292446aa97ae36c0a@realtek.com>
Date:   Tue, 7 Dec 2021 08:20:05 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [RFC PATCH 4/4] r8169: add sysfs for dash

Heiner Kallweit <hkallweit1@...il.com>
> Sent: Tuesday, December 7, 2021 3:38 PM
[...]
> > In addition to protect the critical section, RTNL is used to avoid
> > calling close() before CMAC is finished. The transfer of CMAC
> > may contain several steps. And close() would disable CMAC.
> > I don't wish the CMAC stays at strange state. It may influence
> > the firmware or hardware. Besides, I find the original driver only
> > use RTNL to protect critical section. Is there a better way for it?
> >
> 
> The main issue I see is that you call rtl_dash_from_fw() under RTNL,
> and this function may sleep up to 5s. Holding a system-wide mutex
> for that long isn't too nice.

I would think if there is a better way to replace current one.
Thanks.

> In rtl_dash_info() you just print FW version and build number.
> Wouldn't it be sufficient to print this info once to syslog
> instead of exporting it via sysfs?

It is the information which our user space tool need.
I think it would be replaced with devlink param.

Best Regards,
Hayes