netdev - Re: [PATCH RESEND net-next v2 0/4] WWAN debugfs tweaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZdPi_yk_W6Fn3pXeRBH-YB+Y6yOKMKUOrQ8nv=WOBDKe6XaA@mail.gmail.com>
Date:   Tue, 7 Dec 2021 10:54:46 +0100
From:   Loic Poulain <loic.poulain@...aro.org>
To:     Sergey Ryazanov <ryazanov.s.a@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        M Chetan Kumar <m.chetan.kumar@...el.com>,
        Intel Corporation <linuxwwan@...el.com>,
        Johannes Berg <johannes@...solutions.net>,
        Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH RESEND net-next v2 0/4] WWAN debugfs tweaks

On Tue, 7 Dec 2021 at 10:21, Sergey Ryazanov <ryazanov.s.a@...il.com> wrote:
>
> Resent after dependency [2] was merged to the net-next tree. Added
> Leon's reviewed-by tag from the first V2 submission.
>
> This is a follow-up series to just applied IOSM (and WWAN) debugfs
> interface support [1]. The series has two main goals:
> 1. move the driver-specific debugfs knobs to a subdirectory;
> 2. make the debugfs interface optional for both IOSM and for the WWAN
>    core.
>
> As for the first part, I must say that it was my mistake. I suggested to
> place debugfs entries under a common per WWAN device directory. But I
> missed the driver subdirectory in the example, so it become:
>
> /sys/kernel/debugfs/wwan/wwan0/trace
>
> Since the traces collection is a driver-specific feature, it is better
> to keep it under the driver-specific subdirectory:
>
> /sys/kernel/debugfs/wwan/wwan0/iosm/trace
>
> It is desirable to be able to entirely disable the debugfs interface. It
> can be disabled for several reasons, including security and consumed
> storage space. See detailed rationale with usage example in the 4th
> patch.
>
> The changes themselves are relatively simple, but require a code
> rearrangement. So to make changes clear, I chose to split them into
> preparatory and main changes and properly describe each of them.
>
> IOSM part is compile-tested only since I do not have IOSM supported
> device, so it needs Ack from the driver developers.
>
> I would like to thank Johannes Berg and Leon Romanovsky. Their
> suggestions and comments helped a lot to rework the initial
> over-engineered solution to something less confusing and much more
> simple. Thanks!

Looks good.

Reviewed-by: Loic Poulain <loic.poulain@...aro.org>