[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20211207101920.GB30918@breakpoint.cc>
Date: Tue, 7 Dec 2021 11:19:20 +0100
From: Florian Westphal <fw@...len.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Mat Martineau <mathew.j.martineau@...ux.intel.com>,
netdev@...r.kernel.org, Maxim Galaganov <max@...ernet.ru>,
davem@...emloft.net, matthieu.baerts@...sares.net,
mptcp@...ts.linux.dev, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 10/10] mptcp: support TCP_CORK and TCP_NODELAY
Jakub Kicinski <kuba@...nel.org> wrote:
> On Fri, 3 Dec 2021 14:35:41 -0800 Mat Martineau wrote:
> > +static int mptcp_setsockopt_sol_tcp_nodelay(struct mptcp_sock *msk, sockptr_t optval,
> > + unsigned int optlen)
> > +{
> > + struct mptcp_subflow_context *subflow;
> > + struct sock *sk = (struct sock *)msk;
> > + int val;
> > +
> > + if (optlen < sizeof(int))
> > + return -EINVAL;
> > +
> > + if (copy_from_sockptr(&val, optval, sizeof(val)))
> > + return -EFAULT;
>
> Should we check that optval is not larger than sizeof(int) or if it is
> that the rest of the buffer is zero? Or for the old school options we
> should stick to the old school behavior?
My intent was to stick to tcp behaviour, i.e. no check on > sizeof(int)
or on "extra buffer" content.
Powered by blists - more mailing lists