[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <38b5bff4e24db266537bb8e3161d87c603c020f2.camel@intel.com>
Date: Tue, 7 Dec 2021 10:52:03 +0000
From: "Coelho, Luciano" <luciano.coelho@...el.com>
To: "kuba@...nel.org" <kuba@...nel.org>,
"johannes@...solutions.net" <johannes@...solutions.net>,
"arnd@...nel.org" <arnd@...nel.org>,
"kvalo@...eaurora.org" <kvalo@...eaurora.org>,
"stf_xl@...pl" <stf_xl@...pl>,
"davem@...emloft.net" <davem@...emloft.net>
CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
"Beker, Ayala" <ayala.beker@...el.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH 1/3] iwlwifi: fix LED dependencies
On Tue, 2021-12-07 at 11:49 +0100, Johannes Berg wrote:
> On Tue, 2021-12-07 at 11:16 +0100, Johannes Berg wrote:
> > On Tue, 2021-12-07 at 11:14 +0100, Johannes Berg wrote:
> > > On Sat, 2021-12-04 at 18:38 +0100, Arnd Bergmann wrote:
> > > >
> > > > config IWLWIFI_LEDS
> > > > bool
> > > > - depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI
> > > > + depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> > > >
> > >
> > > Hm. Can we really not have this if LEDS_CLASS=n?
> > >
> >
> > Well, umm. That wouldn't make sense for IWLWIFI_LEDS, sorry.
> >
> > Might be simpler to express this as "depends on MAC80211_LEDS" which has
> > the same condition, and it feels like that makes more sense than
> > referencing MAC80211 here?
> >
>
> Hm, maybe not. Sorry for the monologue here - but MAC80211_LEDS is user
> selectable, and so I guess that's a different thing.
Thanks for checking this, Johannes!
So, if you think we can take Arnd's patch, Kalle has my ack:
Acked-by: Luca Coelho <luciano.coelho@...el.com>
--
Cheers,
Luca.
Powered by blists - more mailing lists