netdev - Re: [PATCH] iwlwifi: work around reverse dependency on MEI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a35HHPs2sMsfQ_SrX4DTKmzidFUOczu8khzwJJTAy++yw@mail.gmail.com>
Date:   Tue, 7 Dec 2021 14:25:52 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>
Cc:     "Coelho, Luciano" <luciano.coelho@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Beker, Ayala" <ayala.beker@...el.com>,
        "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@...el.com>,
        "Berg, Johannes" <johannes.berg@...el.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: work around reverse dependency on MEI

On Tue, Dec 7, 2021 at 2:19 PM Grumbach, Emmanuel
<emmanuel.grumbach@...el.com> wrote:
> > A better option would be change iwl_mei_is_connected() so it could be
> > called from iwlwifi regardless of whether the mei driver is reachable, but that
> > requires a larger rework in the driver.
>
> I can try to do that but I don't really see how..
> I can't really make a function that would behave differently based on whether the symbol is available or not.

I meant that this would be an inline function that only accesses variables
that are available to the iwlwifi driver already, rather than part of the iwlmei
driver.

Part of the problem here is that the current implementation checks a global
variable that is part of the iwlmei driver, so there is no easy way for iwlwifi
to access it.

> >  config IWLMEI
> > -     tristate "Intel Management Engine communication over WLAN"
> > -     depends on INTEL_MEI
> > +     bool "Intel Management Engine communication over WLAN"
> > +     depends on INTEL_MEI=y || INTEL_MEI=IWLMVM
> > +     depends on IWLMVM=y || IWLWIFI=m
> >       depends on PM
> > -     depends on IWLMVM
> >       help
> >         Enables the iwlmei kernel module.
>
> Johannes suggested to make IWLMVM depend on IWLMEI || !IWLMEI
> That worked as well, I just had issues with this in our internal backport based tree.
> I need to spend a bit more time on this, but I admit my total ignorance in Kconfig's dialect.

It's still not enough, the dependency is in iwlwifi, not in iwlmvm, so it
would remain broken for IWLWIFI=y IWLMVM=m IWLMEI=m.

One easy solution might be to link all the iwlmei objects intro the main
iwlwifi driver, the same way it links in the fw/*.c files.

       Arnd