[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <24911380-995a-ece0-41ab-42f6ad6972ff@gmail.com>
Date: Tue, 7 Dec 2021 09:04:43 -0700
From: David Ahern <dsahern@...il.com>
To: Eric Dumazet <eric.dumazet@...il.com>,
"David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>
Cc: netdev <netdev@...r.kernel.org>,
Eric Dumazet <edumazet@...gle.com>,
David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net-next] vrf: use dev_replace_track() for better tracking
On 12/6/21 10:56 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> vrf_rt6_release() and vrf_rtable_release() changes dst->dev
>
> Instead of
>
> dev_hold(ndev);
> dev_put(odev);
>
> We should use
>
> dev_replace_track(odev, ndev, &dst->dev_tracker, GFP_KERNEL);
>
> If we do not transfer dst->dev_tracker to the new device,
> we will get warnings from ref_tracker_dir_exit() when odev
> is finally dismantled.
>
> Fixes: 9038c320001d ("net: dst: add net device refcount tracking to dst_entry")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
> drivers/net/vrf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: David Ahern <dsahern@...nel.org>
Powered by blists - more mailing lists