netdev - Re: [PATCH iproute2-next] tc: Add support for ce_threshold_value/mask in fq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871r2oz4s1.fsf@toke.dk>
Date:   Tue, 07 Dec 2021 18:46:54 +0100
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] tc: Add support for
 ce_threshold_value/mask in fq_codel

David Ahern <dsahern@...il.com> writes:

> [ vger seems to be having problems; just received this ]
>
> On 12/5/21 3:03 PM, Toke Høiland-Jørgensen wrote:
>> David Ahern <dsahern@...il.com> writes:
>> 
>>> On 11/23/21 1:13 PM, Toke Høiland-Jørgensen wrote:
>>>> Commit dfcb63ce1de6 ("fq_codel: generalise ce_threshold marking for subset
>>>> of traffic") added support in fq_codel for setting a value and mask that
>>>> will be applied to the diffserv/ECN byte to turn on the ce_threshold
>>>> feature for a subset of traffic.
>>>>
>>>> This adds support to tc for setting these values. The parameter is
>>>> called ce_threshold_selector and takes a value followed by a
>>>> slash-separated mask. Some examples:
>>>>
>>>>  # apply ce_threshold to ECT(1) traffic
>>>>  tc qdisc replace dev eth0 root fq_codel ce_threshold 1ms ce_threshold_selector 0x1/0x3
>>>>
>>>>  # apply ce_threshold to ECN-capable traffic marked as diffserv AF22
>>>>  tc qdisc replace dev eth0 root fq_codel ce_threshold 1ms ce_threshold_selector 0x50/0xfc
>>>>
>>>> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
>>>> ---
>>>>  tc/q_fq_codel.c | 40 ++++++++++++++++++++++++++++++++++++++++
>>>>  1 file changed, 40 insertions(+)
>>>
>>> please re-send with an update to
>> 
>> With an update to? :)
>> 
>
> ... man page.

Ah yes, of course; will do!

-Toke