netdev - Re: [PATCH] udp: using datalen to cap max gso segments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTSfZf8XCYQEH_LZmEbrfGxhDiRkbvfrC=RULoqqVuVr=-w@mail.gmail.com>
Date:   Wed, 8 Dec 2021 09:58:20 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Jianguo Wu <wujianguo106@....com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] udp: using datalen to cap max gso segments

On Wed, Dec 8, 2021 at 5:03 AM Jianguo Wu <wujianguo106@....com> wrote:
>
> From: Jianguo Wu <wujianguo@...natelecom.cn>
>
> The max number of UDP gso segments is intended to cap to UDP_MAX_SEGMENTS,
> this is checked in udp_send_skb():
>
>     if (skb->len > cork->gso_size * UDP_MAX_SEGMENTS) {
>         kfree_skb(skb);
>         return -EINVAL;
>     }
>
> skb->len contains network and transport header len here, we should use
> only data len instead.
>
> Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT")
> Signed-off-by: Jianguo Wu <wujianguo@...natelecom.cn>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

Thanks Jianguo