netdev - Re: [PATCH v2] net: dsa: mv88e6xxx: error handling for serdes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211208070441.0aef4790@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 8 Dec 2021 07:04:41 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ameer Hamza <amhamza.mgc@...il.com>
Cc:     kabel@...nel.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, olteanv@...il.com, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: dsa: mv88e6xxx: error handling for serdes_power
 functions

On Wed, 8 Dec 2021 19:09:57 +0500 Ameer Hamza wrote:
> I checked serdes.c and I found two methods mv88e6390_serdes_power() and
> mv88e6390_serdes_power() that were not returning ENINVAL in case of
> undefined cmode. Would be appreciated if  you can review the patch
> please.

A note for the future - please put more info into the commit 
message, it shouldn't be necessary to send a follow up email 
with the explanation.