[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YbDkldWhZNDRkZDO@lunn.ch>
Date: Wed, 8 Dec 2021 18:00:05 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Marek BehĂșn <kabel@...nel.org>
Cc: Holger Brunck <holger.brunck@...achienergy.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Jakub Kicinski <kuba@...nel.org>
Subject: Re: [v3 2/2] dsa: mv88e6xxx: make serdes SGMII/Fiber output
amplitude configurable
> Or maybe two properties:
> serdes-tx-amplitude-millivolt = <700 1000 1100>;
> serdes-tx-amplitude-modes = "sgmii", "2500base-x", "10gbase-r";
I think this is good. But you are missing the DT email list from Cc:
You need Robs input.
We probably should list the accepted mode values somehow. I don't know
if we can reference ethernet-controller.yaml : phy-connection-type, or
if we need a new list. This gets interesting when PCIe and USB needs
to use this property, what names are used, and if it is possible to
combine two different lists?
Andrew
Powered by blists - more mailing lists