netdev - Re: [PATCH] nfc: fix segfault in nfc_genl_dump_devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20dcbf40-0ca0-690d-182a-e21ee6af1db4@canonical.com>
Date:   Thu, 9 Dec 2021 09:12:12 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Tadeusz Struk <tadeusz.struk@...aro.org>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, stable@...r.kernel.org,
        syzbot+f9f76f4a0766420b4a02@...kaller.appspotmail.com
Subject: Re: [PATCH] nfc: fix segfault in nfc_genl_dump_devices_done

On 08/12/2021 19:27, Tadeusz Struk wrote:
> When kmalloc in nfc_genl_dump_devices() fails then
> nfc_genl_dump_devices_done() segfaults as below
> 
> KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
> CPU: 0 PID: 25 Comm: kworker/0:1 Not tainted 5.16.0-rc4-01180-g2a987e65025e-dirty #5
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-6.fc35 04/01/2014
> Workqueue: events netlink_sock_destruct_work
> RIP: 0010:klist_iter_exit+0x26/0x80
> Call Trace:
> <TASK>
> class_dev_iter_exit+0x15/0x20
> nfc_genl_dump_devices_done+0x3b/0x50
> genl_lock_done+0x84/0xd0
> netlink_sock_destruct+0x8f/0x270
> __sk_destruct+0x64/0x3b0
> sk_destruct+0xa8/0xd0
> __sk_free+0x2e8/0x3d0
> sk_free+0x51/0x90
> netlink_sock_destruct_work+0x1c/0x20
> process_one_work+0x411/0x710
> worker_thread+0x6fd/0xa80
> 
> Link: https://syzkaller.appspot.com/bug?id=fc0fa5a53db9edd261d56e74325419faf18bd0df
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: netdev@...r.kernel.org
> Cc: stable@...r.kernel.org
> Reported-by: syzbot+f9f76f4a0766420b4a02@...kaller.appspotmail.com
> Signed-off-by: Tadeusz Struk <tadeusz.struk@...aro.org>
> ---
>  net/nfc/netlink.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Cc: <stable@...r.kernel.org>
Fixes: 4d12b8b129f1 ("NFC: add nfc generic netlink interface")

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>

I will fix other similar cases.

Best regards,
Krzysztof