netdev - Re: [PATCH v2] netfilter: fix regression in looped (broad|multi)cast's MAC handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211210150944.GG26636@breakpoint.cc>
Date:   Fri, 10 Dec 2021 16:09:44 +0100
From:   Florian Westphal <fw@...len.de>
To:     Ignacy Gawędzki 
        <ignacy.gawedzki@...en-communications.fr>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v2] netfilter: fix regression in looped
 (broad|multi)cast's MAC handling

Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr> wrote:
> In commit 5648b5e1169f ("netfilter: nfnetlink_queue: fix OOB when mac
> header was cleared"), the test for non-empty MAC header introduced in
> commit 2c38de4c1f8da7 ("netfilter: fix looped (broad|multi)cast's MAC
> handling") has been replaced with a test for a set MAC header, which
> breaks the case when the MAC header has been reset (using
> skb_reset_mac_header), as is the case with looped-back multicast
> packets.

Please rephrase this to say what breaks here.

I guess you get a bogus hwaddr in the netlink message?

Also, this should be sent to netfilter-devel@, not netdev@.

For the patch itself:
Reviewed-by: Florian Westphal <fw@...len.de>