netdev - Re: [PATCH core-next] net/core: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211209185023.2660b7b1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 9 Dec 2021 18:50:23 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     cgel.zte@...il.com
Cc:     davem@...emloft.net, pablo@...filter.org, contact@...elbtn.com,
        justin.iurman@...ege.be, chi.minghao@....com.cn,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zeal Robot <zealci@....com.cm>
Subject: Re: [PATCH core-next] net/core: remove unneeded variable

On Fri, 10 Dec 2021 02:20:12 +0000 cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return status directly from function called.
> 
> Reported-by: Zeal Robot <zealci@....com.cm>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
>  net/core/lwtunnel.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
> index 2820aca2173a..c34248e358ac 100644
> --- a/net/core/lwtunnel.c
> +++ b/net/core/lwtunnel.c
> @@ -63,11 +63,7 @@ static const char *lwtunnel_encap_str(enum lwtunnel_encap_types encap_type)
>  
>  struct lwtunnel_state *lwtunnel_state_alloc(int encap_len)
>  {
> -	struct lwtunnel_state *lws;
> -
> -	lws = kzalloc(sizeof(*lws) + encap_len, GFP_ATOMIC);
> -
> -	return lws;
> +	return kzalloc(sizeof(*lws) + encap_len, GFP_ATOMIC);
>  }
>  EXPORT_SYMBOL_GPL(lwtunnel_state_alloc);

I don't think any of your "remove unneeded variable" patches are worth
applying, sorry.

This one doesn't even build.