netdev - Re: [PATCHv2] net/batman-adv:remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Dec 2021 10:51:44 +0100
From:   Sven Eckelmann <sven@...fation.org>
To:     cgel.zte@...il.com
Cc:     a@...table.cc, b.a.t.m.a.n@...ts.open-mesh.org, cgel.zte@...il.com,
        chi.minghao@....com.cn, davem@...emloft.net, kuba@...nel.org,
        linux-kernel@...r.kernel.org, mareklindner@...mailbox.ch,
        netdev@...r.kernel.org, sw@...onwunderlich.de,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCHv2] net/batman-adv:remove unneeded variable

On Friday, 10 December 2021 10:42:06 CET cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return status directly from function called.
> change since v1: zealci@....com.cm
>              v2: zealci@....com.cn
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---

This is wrong:

1. the patch was already applied
2. the patch history doesn't belong in the commit message
3. there is still an alignment problem
4. if you use -v in git-format-patch then it should be "PATCH v2" and not 
   "PATCHv2" (otherwise it will not be parsed correctly by patchwork)
5. The alignment problem is still there
6. the subject is also not following the normal formatting style

Kind regards,
	Sven
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)