netdev - Re: [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Dec 2021 22:07:49 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     alexandru.tachici@...log.com
Cc:     o.rempel@...gutronix.de, davem@...emloft.net,
        devicetree@...r.kernel.org, hkallweit1@...il.com, kuba@...nel.org,
        linux-kernel@...r.kernel.org, linux@...linux.org.uk,
        netdev@...r.kernel.org, robh+dt@...nel.org
Subject: Re: [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45

> +		ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE);
> +		if (ret < 0)
> +			return ret;
> +
> +		if (ret & MDIO_PMA_EXTABLE_BT1)


This pattern of reading the MDIO_PMA_EXTABLE register and then looking
for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which
is expected to change is it? So i wounder if it should be read once
and stored away?

    Andrew