netdev - Re: [PATCH] igc: Avoid possible deadlock during suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Dec 2021 10:50:30 +0100
From:   Stefan Dietrich <roots@....de>
To:     Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Thorsten Leemhuis <regressions@...mhuis.info>
Cc:     kuba@...nel.org, greg@...ah.com, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, regressions@...ts.linux.dev
Subject: Re: [PATCH] igc: Avoid possible deadlock during suspend/resume

Hi Vinicius,

thanks a lot - that patch fixed it! Both "normal" shutdown as well as
ifdown/ifup are working without issues now if CONFIG_PCIE_PTM is
enabled in the kernel config.

I've done a DSL download/upload speed comparison against my current
5.14.0-19.2 and did not see any performance differences outside margin
of error. I currently have no other Linux machine I could use for iperf
but I will report if I encounter any issues.

As I am not familiar with the kernel development procedure: can you
give a rough estimate when we may expect this patch in the stable
branch?


Thanks again,
Stefan



On Fri, 2021-12-10 at 16:41 -0800, Vinicius Costa Gomes wrote:
> Hi Stefan,
>
> Stefan Dietrich <roots@....de> writes:
>
> > Agreed and thanks for the pointers; please see the log files and
> > .config attached as requested.
> >
>
> Thanks for the logs.
>
> Very interesting that the initialization of the device is fine, so
> it's
> something that happens later.
>
> Can you test the attached patch?
>
> If the patch works, I would also be interested if you notice any loss
> of
> functionality with your NIC. (I wouldn't think so, as far as I know,
> i225-V models have PTM support but don't have any PTP support).
>
> > Cheers,
> > Stefan
> >
> >
> > On Fri, 2021-12-10 at 15:01 +0100, Thorsten Leemhuis wrote:
> > > On 10.12.21 14:45, Stefan Dietrich wrote:
> > > > thanks for keeping an eye on the issue. I've sent the files in
> > > > private
> > > > because I did not want to spam the mailing lists with them.
> > > > Please
> > > > let
> > > > me know if this is the correct procedure.
>
> Cheers,