netdev - RE: [PATCH net-next 2/2] net: stmmac: add tc flower filter for EtherType matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB2780AF6CA7085765EBA0C818CA729@DM6PR11MB2780.namprd11.prod.outlook.com>
Date:   Sat, 11 Dec 2021 14:03:06 +0000
From:   "Ong, Boon Leong" <boon.leong.ong@...el.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "Kanzenbach, Kurt" <kurt.kanzenbach@...utronix.de>
CC:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Maxime Coquelin" <mcoquelin.stm32@...il.com>,
        "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH net-next 2/2] net: stmmac: add tc flower filter for
 EtherType matching

>On 2021-12-10 11:10:04 [+0100], Kurt Kanzenbach wrote:
>> > +	if (match.mask->n_proto) {
>> > +		__be16 etype = ntohs(match.key->n_proto);
>>
>> n_proto is be16. The ntohs() call will produce an u16.
>
>While at it, could we be please remove that __force in
>ETHER_TYPE_FULL_MASK and use cpu_to_be16() macro?
>
>> Thanks,
>> Kurt
>
>Sebastian

Thanks. Will do.