netdev - RE: [PATCH v6 net-next 03/12] flow_offload: add index to flow_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Dec 2021 08:41:23 +0000
From:   Baowen Zheng <baowen.zheng@...igine.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>,
        Simon Horman <simon.horman@...igine.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Cong Wang <xiyou.wangcong@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Ido Schimmel <idosch@...dia.com>,
        Jiri Pirko <jiri@...nulli.us>, Oz Shlomo <ozsh@...dia.com>,
        Roi Dayan <roid@...dia.com>, Vlad Buslov <vladbu@...dia.com>,
        Louis Peens <louis.peens@...igine.com>,
        oss-drivers <oss-drivers@...igine.com>
Subject: RE: [PATCH v6 net-next 03/12] flow_offload: add index to
 flow_action_entry structure

On December 12, 2021 3:10 AM, Jamal Hadi Salim wrote:
>On 2021-12-09 04:27, Simon Horman wrote:
>
>> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
>> index 3961461d9c8b..f6970213497a 100644
>> --- a/include/net/flow_offload.h
>> +++ b/include/net/flow_offload.h
>> @@ -197,6 +197,7 @@ void flow_action_cookie_destroy(struct
>> flow_action_cookie *cookie);
>>
>>   struct flow_action_entry {
>>   	enum flow_action_id		id;
>> +	u32				index;
>>   	enum flow_action_hw_stats	hw_stats;
>>   	action_destr			destructor;
>>   	void				*destructor_priv;
>
>
>Because "index" is such a common noun - can you name this one "hw_index"
>for grep-ability?
Ok we will rename the index to something like " hw_index " as your suggestion.
Thanks
>
>cheers,
>jamal