netdev - RE: [EXT] Re: [PATCH net-next] net: stmmac: bump tc when get underflow error from DMA descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Dec 2021 00:49:03 +0000
From:   Xiaoliang Yang <xiaoliang.yang_1@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Joakim Zhang <qiangqing.zhang@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        Yannick Vignon <yannick.vignon@....com>,
        "boon.leong.ong@...el.com" <boon.leong.ong@...el.com>,
        "Jose.Abreu@...opsys.com" <Jose.Abreu@...opsys.com>,
        "mst@...hat.com" <mst@...hat.com>,
        "Joao.Pinto@...opsys.com" <Joao.Pinto@...opsys.com>,
        Mingkai Hu <mingkai.hu@....com>, Leo Li <leoyang.li@....com>
Subject: RE: [EXT] Re: [PATCH net-next] net: stmmac: bump tc when get
 underflow error from DMA descriptor


On Fri, 11 Dec 2021 00:07:13 Jakub Kicinski wrote:
> > > > 5 queues with FIFO cut-through mode can work well after applying this
> patch.
> > >
> > > This never worked, correct? It's not a regression fix?
> >
> > Yes, it's never worked when the underflow error is observed in the
> > case of NFS boot on i.mx8mp. I'm not sure if other SoC have same issue
> > in this case, but I think it's necessary to increase the threshold
> > value in case of underflow error.
> 
> Oh, so NFS boot works for the most part on i.mx8mp but under certain
> conditions (or with certain configuration?) this error can be observed and the
> boot will fail?
Yes, when configure the DMA as threshold mode, this error can be observed.

> 
> > Do you mean that I need to send the patch as a bug fix to net branch?
> 
> Your call, if you would like for the patch to go to stable and LTS releases -- then
> it need to be resent for net with a Fixes tag.
> 
> LMK if you prefer net or net-next.
Because this error requires a certain condition in DTS file, and I haven't update the DTS file. So I prefer to add the patch in net-next, thanks.