netdev - Re: [PATCH 06/12] selftests/landlock: remove ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ab490d6-ac17-8383-4c84-e4cbcbd7fab0@digikod.net>
Date:   Mon, 13 Dec 2021 16:36:27 +0100
From:   Mickaël Salaün <mic@...ikod.net>
To:     Shuah Khan <skhan@...uxfoundation.org>, catalin.marinas@....com,
        will@...nel.org, shuah@...nel.org, keescook@...omium.org,
        davem@...emloft.net, kuba@...nel.org, peterz@...radead.org,
        paulmck@...nel.org, boqun.feng@...il.com, akpm@...ux-foundation.org
Cc:     linux-kselftest@...r.kernel.org,
        linux-security-module@...r.kernel.org, netdev@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH 06/12] selftests/landlock: remove ARRAY_SIZE define from
 common.h


On 10/12/2021 18:33, Shuah Khan wrote:
> ARRAY_SIZE is defined in several selftests. Remove definitions from
> individual test files and include header file for the define instead.
> ARRAY_SIZE define is added in a separate patch to prepare for this
> change.
> 
> Remove ARRAY_SIZE from common.h and pickup the one defined in
> kselftest.h.
> 
> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>

Acked-by: Mickaël Salaün <mic@...ikod.net>

> ---
>   tools/testing/selftests/landlock/common.h | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/landlock/common.h b/tools/testing/selftests/landlock/common.h
> index 20e2a9286d71..183b7e8e1b95 100644
> --- a/tools/testing/selftests/landlock/common.h
> +++ b/tools/testing/selftests/landlock/common.h
> @@ -17,10 +17,6 @@
>   
>   #include "../kselftest_harness.h"
>   
> -#ifndef ARRAY_SIZE
> -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
> -#endif
> -
>   /*
>    * TEST_F_FORK() is useful when a test drop privileges but the corresponding
>    * FIXTURE_TEARDOWN() requires them (e.g. to remove files from a directory
>