netdev - Re: [PATCH 01/12] tools: fix ARRAY_SIZE defines in tools and selftests hdrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202112131238.24E1713A0@keescook>
Date:   Mon, 13 Dec 2021 12:38:10 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     catalin.marinas@....com, will@...nel.org, shuah@...nel.org,
        mic@...ikod.net, davem@...emloft.net, kuba@...nel.org,
        peterz@...radead.org, paulmck@...nel.org, boqun.feng@...il.com,
        akpm@...ux-foundation.org, linux-kselftest@...r.kernel.org,
        linux-security-module@...r.kernel.org, netdev@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH 01/12] tools: fix ARRAY_SIZE defines in tools and
 selftests hdrs

On Fri, Dec 10, 2021 at 10:33:11AM -0700, Shuah Khan wrote:
> tools/include/linux/kernel.h and kselftest_harness.h are missing
> ifndef guard around ARRAY_SIZE define. Fix them to avoid duplicate
> define errors during compile when another file defines it. This
> problem was found when compiling selftests that include a header
> with ARRAY_SIZE define.
> 
> ARRAY_SIZE is defined in several selftests. There are about 25+
> duplicate defines in various selftests source and header files.
> Add ARRAY_SIZE to kselftest.h in preparation for removing duplicate
> ARRAY_SIZE defines from individual test files.
> 
> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook