netdev - Re: [PATCH v6 net-next 00/12] allow user to offload tc action to net device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211213091643.GA2266@corigine.com>
Date:   Mon, 13 Dec 2021 10:16:44 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>
Cc:     netdev@...r.kernel.org, Cong Wang <xiyou.wangcong@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Ido Schimmel <idosch@...dia.com>,
        Jiri Pirko <jiri@...nulli.us>, Oz Shlomo <ozsh@...dia.com>,
        Roi Dayan <roid@...dia.com>, Vlad Buslov <vladbu@...dia.com>,
        Baowen Zheng <baowen.zheng@...igine.com>,
        Louis Peens <louis.peens@...igine.com>,
        oss-drivers@...igine.com
Subject: Re: [PATCH v6 net-next 00/12] allow user to offload tc action to net
 device

Hi Jamal,

thanks for your review.
We'll work on the issues raised in this thread.

On Sat, Dec 11, 2021 at 02:04:50PM -0500, Jamal Hadi Salim wrote:
> Hi,
> 
> I believe these patches are functionally ready. There is still some
> nitpick.
> 
> On the general patch: Why not Cc the maintainers for the drivers you
> are touching? I know the changes seem trivial but it is good courtesy.

Thanks. For some reason that had not occurred to me.
I'll try to make it so in v7.

> From your logs driver files touched:
> 
>    drivers/net/dsa/ocelot/felix_vsc9959.c        |   4 +-
>    drivers/net/dsa/sja1105/sja1105_flower.c      |   2 +-
>    drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c  |   2 +-
>    .../net/ethernet/freescale/enetc/enetc_qos.c  |   6 +-
>    .../ethernet/mellanox/mlx5/core/en/rep/tc.c   |   3 +
>    .../ethernet/mellanox/mlxsw/spectrum_flower.c |   2 +-
>    drivers/net/ethernet/mscc/ocelot_flower.c     |   2 +-
>    .../ethernet/netronome/nfp/flower/offload.c   |   3 +
> 
> Also - shouldnt the history be all inclusive? You obly have V5 here.
> Maybe with lore or patchwork this is no longer necessary and all
> history can be retrieved in the future?

Sure, can do.

...