netdev - RE: [Intel-wired-lan] [PATCH net] iavf: do not override the adapter state in the watchdog task (again)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM8PR11MB562126C8EE3AC17F4CDF0763AB749@DM8PR11MB5621.namprd11.prod.outlook.com>
Date:   Mon, 13 Dec 2021 13:27:54 +0000
From:   "Jankowski, Konrad0" <konrad0.jankowski@...el.com>
To:     Stefan Assmann <sassmann@...nic.de>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Palczewski, Mateusz" <mateusz.palczewski@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH net] iavf: do not override the adapter
 state in the watchdog task (again)



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Stefan Assmann
> Sent: środa, 1 grudnia 2021 09:15
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; sassmann@...nic.de; Palczewski, Mateusz
> <mateusz.palczewski@...el.com>
> Subject: [Intel-wired-lan] [PATCH net] iavf: do not override the adapter state
> in the watchdog task (again)
> 
> The watchdog task incorrectly changes the state to __IAVF_RESETTING,
> instead of letting the reset task take care of that. This was already resolved
> by
> 22c8fd71d3a5 iavf: do not override the adapter state in the watchdog task
> but the problem was reintroduced by the recent code refactoring in
> 45eebd62999d.
> 
> Fixes: 45eebd62999d ("iavf: Refactor iavf state machine tracking")
> 
> Signed-off-by: Stefan Assmann <sassmann@...nic.de>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 14934a7a13ef..360dfb7594cb 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -2085,7 +2085,6 @@ static void iavf_watchdog_task(struct work_struct

Tested-by: Konrad Jankowski <konrad0.jankowski@...el.com>