netdev - [PATCH net-next 0/3] DSA tagger-owned storage fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Dec 2021 03:45:33 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ansuel Smith <ansuelsmth@...il.com>
Subject: [PATCH net-next 0/3] DSA tagger-owned storage fixups

It seems that the DSA tagger-owned storage changes were insufficiently
tested and do not work in all cases. Specifically, the NXP Bluebox 3
(arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dts) got broken by
these changes, because
(a) I forgot that DSA_TAG_PROTO_SJA1110 exists and differs from
    DSA_TAG_PROTO_SJA1105
(b) the Bluebox 3 uses a DSA switch tree with 2 switches, and the
    tagger-owned storage patches don't cover that use case well, it
    seems

Therefore, I'm sorry to say that there needs to be an API fixup: tagging
protocol drivers will from now on connect to individual switches from a
tree, rather than to the tree as a whole. This is more robust against
various ordering constraints in the DSA probe and teardown paths, and is
also symmetrical with the connection API exposed to the switch drivers
themselves, which is also per switch.

With these changes, the Bluebox 3 also works fine.

Vladimir Oltean (3):
  net: dsa: tag_sja1105: fix zeroization of ds->priv on tag proto
    disconnect
  net: dsa: sja1105: fix broken connection with the sja1110 tagger
  net: dsa: make tagging protocols connect to individual switches from a
    tree

 drivers/net/dsa/sja1105/sja1105_main.c | 16 +++---
 include/linux/dsa/sja1105.h            |  3 +-
 include/net/dsa.h                      |  5 +-
 net/dsa/dsa2.c                         | 44 +++++++----------
 net/dsa/dsa_priv.h                     |  1 +
 net/dsa/switch.c                       | 52 ++++++++++++++++++--
 net/dsa/tag_ocelot_8021q.c             | 53 ++++++--------------
 net/dsa/tag_sja1105.c                  | 67 +++++++++-----------------
 8 files changed, 119 insertions(+), 122 deletions(-)

-- 
2.25.1