netdev - Re: [PATCH bpf-next] selftests/bpf: Fix building error when using userspace pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9063be69-fbd9-c0a5-9271-c6d4281c71ef@iogearbox.net>
Date:   Tue, 14 Dec 2021 21:01:43 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Pu Lehui <pulehui@...wei.com>, ast@...nel.org, andrii@...nel.org,
        kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org,
        paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, shuah@...nel.org
Cc:     linux-kselftest@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix building error when using
 userspace pt_regs

On 12/14/21 2:55 PM, Pu Lehui wrote:
> When building bpf selftests on arm64, the following error will occur:
> 
> progs/loop2.c:20:7: error: incomplete definition of type 'struct
> user_pt_regs'
> 
> Some archs, like arm64 and riscv, use userspace pt_regs in
> bpf_tracing.h, which causes build failure when bpf prog use
> macro in bpf_tracing.h. So let's use vmlinux.h directly.
> 
> Signed-off-by: Pu Lehui <pulehui@...wei.com>

Looks like this lets CI fail, did you run the selftests also with vmtest.sh to
double check?

https://github.com/kernel-patches/bpf/runs/4521708490?check_suite_focus=true :

[...]
#189 verif_scale_loop6:FAIL
libbpf: prog 'trace_virtqueue_add_sgs': BPF program load failed: Argument list too long
libbpf: prog 'trace_virtqueue_add_sgs': -- BEGIN PROG LOAD LOG --
R1 type=ctx expected=fp
BPF program is too large. Processed 1000001 insn
verification time 12250995 usec
stack depth 88
processed 1000001 insns (limit 1000000) max_states_per_insn 107 total_states 21739 peak_states 2271 mark_read 6
-- END PROG LOAD LOG --
libbpf: failed to load program 'trace_virtqueue_add_sgs'
libbpf: failed to load object 'loop6.o'
scale_test:FAIL:expect_success unexpected error: -7 (errno 7)
Summary: 221/986 PASSED, 8 SKIPPED, 1 FAILED
[...]

Please take a look and fix in your patch, thanks!