netdev - Re: [PATCH v6 net-next 00/12] allow user to offload tc action to net device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Dec 2021 08:55:55 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Vlad Buslov <vladbu@...dia.com>
Cc:     netdev@...r.kernel.org, Cong Wang <xiyou.wangcong@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Ido Schimmel <idosch@...dia.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>, Oz Shlomo <ozsh@...dia.com>,
        Roi Dayan <roid@...dia.com>,
        Baowen Zheng <baowen.zheng@...igine.com>,
        Louis Peens <louis.peens@...igine.com>,
        oss-drivers@...igine.com
Subject: Re: [PATCH v6 net-next 00/12] allow user to offload tc action to net
 device

On Mon, Dec 13, 2021 at 09:21:54PM +0200, Vlad Buslov wrote:
> On Thu 09 Dec 2021 at 11:27, Simon Horman <simon.horman@...igine.com> wrote:
> > Baowen Zheng says:
> >
> > Allow use of flow_indr_dev_register/flow_indr_dev_setup_offload to offload
> > tc actions independent of flows.
> >
> > The motivation for this work is to prepare for using TC police action
> > instances to provide hardware offload of OVS metering feature - which calls
> > for policers that may be used by multiple flows and whose lifecycle is
> > independent of any flows that use them.
> >
> > This patch includes basic changes to offload drivers to return EOPNOTSUPP
> > if this feature is used - it is not yet supported by any driver.
> >
> > Tc cli command to offload and quote an action:
> >
> >  # tc qdisc del dev $DEV ingress && sleep 1 || true
> >  # tc actions delete action police index 200 || true
> >
> >  # tc qdisc add dev $DEV ingress
> >  # tc qdisc show dev $DEV ingress
> >
> >  # tc actions add action police rate 100mbit burst 10000k index 200 skip_sw
> >  # tc -s -d actions list action police
> >  total acts 1
> >
> >          action order 0:  police 0xc8 rate 100Mbit burst 10000Kb mtu 2Kb action reclassify 
> >          overhead 0b linklayer ethernet
> >          ref 1 bind 0  installed 142 sec used 0 sec
> >          Action statistics:
> >          Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
> >          backlog 0b 0p requeues 0
> >          skip_sw in_hw in_hw_count 1
> >          used_hw_stats delayed
> >
> >  # tc filter add dev $DEV protocol ip parent ffff: \
> >          flower skip_sw ip_proto tcp action police index 200
> >  # tc -s -d filter show dev $DEV protocol ip parent ffff:
> >  filter pref 49152 flower chain 0
> >  filter pref 49152 flower chain 0 handle 0x1
> >    eth_type ipv4
> >    ip_proto tcp
> >    skip_sw
> >    in_hw in_hw_count 1
> >          action order 1:  police 0xc8 rate 100Mbit burst 10000Kb mtu 2Kb action 
> >          reclassify overhead 0b linklayer ethernet
> >          ref 2 bind 1  installed 300 sec used 0 sec
> >          Action statistics:
> >          Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
> >          backlog 0b 0p requeues 0
> >          skip_sw in_hw in_hw_count 1
> >          used_hw_stats delayed
> >
> >  # tc filter add dev $DEV protocol ipv6 parent ffff: \
> >          flower skip_sw ip_proto tcp action police index 200
> >  # tc -s -d filter show dev $DEV protocol ipv6 parent ffff:
> >    filter pref 49151 flower chain 0
> >    filter pref 49151 flower chain 0 handle 0x1
> >    eth_type ipv6
> >    ip_proto tcp
> >    skip_sw
> >    in_hw in_hw_count 1
> >          action order 1:  police 0xc8 rate 100Mbit burst 10000Kb mtu 2Kb action 
> >          reclassify overhead 0b linklayer ethernet
> >          ref 3 bind 2  installed 761 sec used 0 sec
> >          Action statistics:
> >          Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
> >          backlog 0b 0p requeues 0
> >          skip_sw in_hw in_hw_count 1
> >          used_hw_stats delayed
> >
> >  # tc -s -d actions list action police
> >  total acts 1
> >
> >           action order 0:  police 0xc8 rate 100Mbit burst 10000Kb mtu 2Kb action reclassify overhead 0b linklayer ethernet
> >           ref 3 bind 2  installed 917 sec used 0 sec
> >           Action statistics:
> >           Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
> >           backlog 0b 0p requeues 0
> >           skip_sw in_hw in_hw_count 1
> >          used_hw_stats delayed
> >
> > Changes compared to v5 patches:
> > * Fix issue reported by Dan Carpenter found using Smatch.
> 
> Hi,
> 
> Sorry for late response to this and previous version. From my side
> series LGTM besides points raised by Jamal and Roi.

Thanks Vlad,

we appreciate your reviews.  We'll work on addressing the points made by
Jamal and Roi and repost accordingly.