netdev - Re: [PATCH net] net: dsa: hellcreek: Allow PTP on blocked ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zgp338pd.fsf@kurt>
Date:   Tue, 14 Dec 2021 09:13:34 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Kamil Alkhouri <kamil.alkhouri@...offenburg.de>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: hellcreek: Allow PTP on blocked ports

Hi Richard,

On Mon Dec 13 2021, Richard Cochran wrote:
> On Mon, Dec 13, 2021 at 11:18:10AM +0100, Kurt Kanzenbach wrote:
>
>> @@ -1055,7 +1058,7 @@ static int hellcreek_setup_fdb(struct hellcreek *hellcreek)
>>  		.portmask     = 0x03,	/* Management ports */
>>  		.age	      = 0,
>>  		.is_obt	      = 0,
>> -		.pass_blocked = 0,
>> +		.pass_blocked = 1,
>
> This one should stay blocked.

You're right. I confirmed with Hirschmann. Only peer delay measurements
should be allowed on blocked ports. In addition, we also have to add
static entries for STP with pass_blocked bit set. Furthermore, the UDP
entries are missing as well. Currently it only works for 802.1AS even
though the driver happily announces V2_EVENT capability.

I'll clean it up and resend properly.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)