netdev - Re: [PATCH iproute2-next v2] tc: Add support for ce_threshold_value/mask in fq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877dc7za4u.fsf@toke.dk>
Date:   Tue, 14 Dec 2021 12:41:37 +0100
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next v2] tc: Add support for
 ce_threshold_value/mask in fq_codel

David Ahern <dsahern@...il.com> writes:

> On 12/8/21 5:45 AM, Toke Høiland-Jørgensen wrote:
>> Commit dfcb63ce1de6 ("fq_codel: generalise ce_threshold marking for subset
>> of traffic") added support in fq_codel for setting a value and mask that
>> will be applied to the diffserv/ECN byte to turn on the ce_threshold
>> feature for a subset of traffic.
>> 
>> This adds support to iproute for setting these values. The parameter is
>> called ce_threshold_selector and takes a value followed by a
>> slash-separated mask. Some examples:
>> 
>>  # apply ce_threshold to ECT(1) traffic
>>  tc qdisc replace dev eth0 root fq_codel ce_threshold 1ms ce_threshold_selector 0x1/0x3
>> 
>>  # apply ce_threshold to ECN-capable traffic marked as diffserv AF22
>>  tc qdisc replace dev eth0 root fq_codel ce_threshold 1ms ce_threshold_selector 0x50/0xfc
>> 
>> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
>> ---
>> v2:
>> - Also update man page
>> 
>>  man/man8/tc-fq_codel.8 | 11 +++++++++++
>>  tc/q_fq_codel.c        | 40 ++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 51 insertions(+)
>> 
>
> please remember to cc Stephen and I on iproute2 patches. Otherwise you
> are at the mercy of vger - from wild delays in delivery time to
> unsubscribing accounts in which case I would never get it.

Right, will do, sorry about that! :)

-Toke