netdev - Re: [PATCH v3 net-next 1/2] fib: rules: remove duplicated nla policies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d09956b9-bf36-fe05-8170-cd73ccc91ee0@gmail.com>
Date:   Wed, 15 Dec 2021 08:38:37 -0700
From:   David Ahern <dsahern@...il.com>
To:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, dsahern@...nel.org
Subject: Re: [PATCH v3 net-next 1/2] fib: rules: remove duplicated nla
 policies

On 12/15/21 4:32 AM, Florian Westphal wrote:
> The attributes are identical in all implementations so move the ipv4 one
> into the core and remove the per-family nla policies.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---
>  resend without changes.
> 
>  include/net/fib_rules.h | 1 -
>  net/core/fib_rules.c    | 9 +++++++--
>  net/decnet/dn_rules.c   | 5 -----
>  net/ipv4/fib_rules.c    | 6 ------
>  net/ipv4/ipmr.c         | 5 -----
>  net/ipv6/fib6_rules.c   | 5 -----
>  net/ipv6/ip6mr.c        | 5 -----
>  7 files changed, 7 insertions(+), 29 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>

The extra FRA_FLOW across rule sets should be fine since it is using
nlmsg_parse_deprecated.