netdev - Re: [PATCH v3] cgroup/bpf: fast path skb BPF filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <634c2c87-84c9-0254-3f12-7d993037495c@gmail.com>
Date:   Wed, 15 Dec 2021 17:53:42 +0000
From:   Pavel Begunkov <asml.silence@...il.com>
To:     sdf@...gle.com
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] cgroup/bpf: fast path skb BPF filtering

On 12/15/21 17:33, sdf@...gle.com wrote:
> On 12/15, Pavel Begunkov wrote:
>> On 12/15/21 16:51, sdf@...gle.com wrote:
>> > On 12/15, Pavel Begunkov wrote:
>> > > � /* Wrappers for __cgroup_bpf_run_filter_skb() guarded by cgroup_bpf_enabled. */
>> > > � #define BPF_CGROUP_RUN_PROG_INET_INGRESS(sk, skb)����������������� \
>> > > � ({����������������������������������������� \
>> > > ����� int __ret = 0;��������������������������������� \
>> > > -��� if (cgroup_bpf_enabled(CGROUP_INET_INGRESS))������������� \
>> > > +��� if (cgroup_bpf_enabled(CGROUP_INET_INGRESS) && sk &&������������� \
>> > > +������� CGROUP_BPF_TYPE_ENABLED((sk), CGROUP_INET_INGRESS))���������� \
>> >
>> > Why not add this __cgroup_bpf_run_filter_skb check to
>> > __cgroup_bpf_run_filter_skb? Result of sock_cgroup_ptr() is already there
>> > and you can use it. Maybe move the things around if you want
>> > it to happen earlier.
> 
>> For inlining. Just wanted to get it done right, otherwise I'll likely be
>> returning to it back in a few months complaining that I see measurable
>> overhead from the function call :)
> 
> Do you expect that direct call to bring any visible overhead?
> Would be nice to compare that inlined case vs
> __cgroup_bpf_prog_array_is_empty inside of __cgroup_bpf_run_filter_skb
> while you're at it (plus move offset initialization down?).

Sorry but that would be waste of time. I naively hope it will be visible
with net at some moment (if not already), that's how it was with io_uring,
that's what I see in the block layer. And in anyway, if just one inlined
won't make a difference, then 10 will.

-- 
Pavel Begunkov