netdev - Re: [PATCH net-next 1/7] net: phylink: add mac_select_pcs() method to phylink_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211214183507.736f8fdc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 14 Dec 2021 18:35:07 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Marcin Wojtas <mw@...ihalf.com>, netdev@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH net-next 1/7] net: phylink: add mac_select_pcs() method
 to phylink_mac_ops

On Tue, 14 Dec 2021 14:48:05 +0000 Russell King (Oracle) wrote:
> +/**
> + * @mac_select_pcs: Select a PCS for the interface mode.

nit: no '@' in front of the function name

> + * @config: a pointer to a &struct phylink_config.
> + * @interface: PHY interface mode for PCS
> + *
> + * Return the &struct phylink_pcs for the specified interface mode, or
> + * NULL if none is required, or an error pointer on error.
> + *
> + * This must not modify any state. It is used to query which PCS should
> + * be used. Phylink will use this during validation to ensure that the
> + * configuration is valid, and when setting a configuration to internally
> + * set the PCS that will be used.
> + */
> +struct phylink_pcs *mac_select_pcs(struct phylink_config *config,
> +				   phy_interface_t interface);