netdev - Re: [RFC PATCH v2 net-next] net: Preserve skb delivery time during forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7567da39-cf7c-ce8e-e2b1-34f517ca74e9@ssi.bg>
Date:   Thu, 16 Dec 2021 00:07:39 +0200 (EET)
From:   Julian Anastasov <ja@....bg>
To:     Martin KaFai Lau <kafai@...com>
cc:     netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>, kernel-team@...com,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [RFC PATCH v2 net-next] net: Preserve skb delivery time during
 forward


	Hello,

On Wed, 15 Dec 2021, Martin KaFai Lau wrote:

> diff --git a/net/ipv4/ip_forward.c b/net/ipv4/ip_forward.c
> index 00ec819f949b..f216fc97c6ce 100644
> --- a/net/ipv4/ip_forward.c
> +++ b/net/ipv4/ip_forward.c
> @@ -79,7 +79,7 @@ static int ip_forward_finish(struct net *net, struct sock *sk, struct sk_buff *s
>  	if (unlikely(opt->optlen))
>  		ip_forward_options(skb);
>  
> -	skb->tstamp = 0;
> +	skb_scrub_tstamp(skb);

	Just to let you know, you can consider all places in
net/netfilter/ipvs/ip_vs_xmit.c that reset tstamp as a forwarding path
like this one.

>  	return dst_output(net, sk, skb);
>  }

Regards

--
Julian Anastasov <ja@....bg>