netdev - Re: [PATCH net] netfilter: nftables: fix use-after-free in nft_set_catchall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ybpvt4NgxoSlfbAQ@salvia>
Date:   Wed, 15 Dec 2021 23:44:07 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        netfilter-devel@...r.kernel.org, netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net] netfilter: nftables: fix use-after-free in
 nft_set_catchall_destroy()

On Mon, Dec 13, 2021 at 05:45:44AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> We need to use list_for_each_entry_safe() iterator
> because we can not access @catchall after kfree_rcu() call.
> 
> syzbot reported:
> 
> BUG: KASAN: use-after-free in nft_set_catchall_destroy net/netfilter/nf_tables_api.c:4486 [inline]
> BUG: KASAN: use-after-free in nft_set_destroy net/netfilter/nf_tables_api.c:4504 [inline]
> BUG: KASAN: use-after-free in nft_set_destroy+0x3fd/0x4f0 net/netfilter/nf_tables_api.c:4493
> Read of size 8 at addr ffff8880716e5b80 by task syz-executor.3/8871

Applied to nf, thanks