netdev - [PATCH -next] lib: TEST_REF_TRACKER should depend on REF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <0b6c06487234b0fb52b7a2fbd2237af42f9d11a6.1639560869.git.geert+renesas@glider.be>
Date:   Wed, 15 Dec 2021 10:36:18 +0100
From:   Geert Uytterhoeven <geert+renesas@...der.be>
To:     Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: [PATCH -next] lib: TEST_REF_TRACKER should depend on REF_TRACKER instead of selecting it

TEST_REF_TRACKER selects REF_TRACKER, thus enabling an optional feature
the user may not want to have enabled.  Fix this by making the test
depend on REF_TRACKER instead.

Fixes: 914a7b5000d08f14 ("lib: add tests for reference tracker")
Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
---
 lib/Kconfig.debug | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index c77fe36bb3d89685..d5e4afee09d78a1e 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2114,8 +2114,7 @@ config BACKTRACE_SELF_TEST
 
 config TEST_REF_TRACKER
 	tristate "Self test for reference tracker"
-	depends on DEBUG_KERNEL && STACKTRACE_SUPPORT
-	select REF_TRACKER
+	depends on DEBUG_KERNEL && STACKTRACE_SUPPORT && REF_TRACKER
 	help
 	  This option provides a kernel module performing tests
 	  using reference tracker infrastructure.
-- 
2.25.1