netdev - Re: [PATCH net-next 01/13] dt-bindings: net: dsa: realtek-smi: remove unsupported switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f288fb5-3497-1529-c715-146e3c4dae83@bang-olufsen.dk>
Date:   Thu, 16 Dec 2021 23:20:53 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     "luizluca@...il.com" <luizluca@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "arinc.unal@...nc9.com" <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next 01/13] dt-bindings: net: dsa: realtek-smi: remove
 unsupported switches

On 12/16/21 21:13, luizluca@...il.com wrote:
> From: Luiz Angelo Daros de Luca <luizluca@...il.com>
> 
> Remove some switch models that are not cited in the code. Although rtl8366s
> was kept, it looks like a stub driver (with a FIXME comment).

Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>

> 
> Reviewed-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> ---
>   .../devicetree/bindings/net/dsa/realtek-smi.txt          | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt b/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt
> index 7959ec237983..3a60e77ceed4 100644
> --- a/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/realtek-smi.txt
> @@ -4,20 +4,15 @@ Realtek SMI-based Switches
>   The SMI "Simple Management Interface" is a two-wire protocol using
>   bit-banged GPIO that while it reuses the MDIO lines MCK and MDIO does
>   not use the MDIO protocol. This binding defines how to specify the
> -SMI-based Realtek devices.
> +SMI-based Realtek devices. The realtek-smi driver is a platform driver
> +and it must be inserted inside a platform node.
>   
>   Required properties:
>   
>   - compatible: must be exactly one of:
>         "realtek,rtl8365mb" (4+1 ports)
> -      "realtek,rtl8366"
>         "realtek,rtl8366rb" (4+1 ports)
>         "realtek,rtl8366s"  (4+1 ports)
> -      "realtek,rtl8367"
> -      "realtek,rtl8367b"
> -      "realtek,rtl8368s"  (8 port)
> -      "realtek,rtl8369"
> -      "realtek,rtl8370"   (8 port)
>   
>   Required properties:
>   - mdc-gpios: GPIO line for the MDC clock line.