netdev - Re: [PATCH net-next 07/13] net: dsa: rtl8365mb: rename rtl8365mb to rtl8367c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fbf5793-8635-557b-79f2-39b70b141ba3@bang-olufsen.dk>
Date:   Thu, 16 Dec 2021 23:41:59 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     "luizluca@...il.com" <luizluca@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "arinc.unal@...nc9.com" <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next 07/13] net: dsa: rtl8365mb: rename rtl8365mb to
 rtl8367c

Hi Luiz,

On 12/16/21 21:13, luizluca@...il.com wrote:
> From: Luiz Angelo Daros de Luca <luizluca@...il.com>
> 
> rtl8365mb refers to a single device supported by the driver.
> The rtl8367c does not refer to any real device, but it is the
> driver version name used by Realtek.
> 
> Tested-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> ---
>   drivers/net/dsa/realtek/Kconfig       |    9 +-
>   drivers/net/dsa/realtek/Makefile      |    2 +-
>   drivers/net/dsa/realtek/realtek-smi.c |    4 +-
>   drivers/net/dsa/realtek/realtek.h     |    2 +-
>   drivers/net/dsa/realtek/rtl8367c.c    | 1321 ++++++++++++-------------
>   drivers/net/phy/realtek.c             |    2 +-
>   6 files changed, 666 insertions(+), 674 deletions(-)
> 

Is the rename really necessary? My logic in naming it rtl8365mb was 
simply that it was the first hardware to be supported by the driver, 
which was more meaningful than Realtek's fictitious rtl8367c. This seems 
to be common practice in the kernel, and bulk renames don't normally 
bring much value.

I think the vendor's naming scheme is confusing at best, so it's better 
to stick to real things in the kernel.

	Alvin