netdev - Re: [PATCH net-next 3/3] net: amd-xgbe: Disable the CDR workaround path for Yellow Carp Devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85ffbb22-c808-b2f6-980e-4ee6a294ed98@amd.com>
Date:   Fri, 17 Dec 2021 08:30:09 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Raju Rangoju <rrangoju@....com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     netdev@...r.kernel.org, Shyam-sundar.S-k@....com,
        Sudheesh.Mavila@....com, Raju.Rangoju@....com
Subject: Re: [PATCH net-next 3/3] net: amd-xgbe: Disable the CDR workaround
 path for Yellow Carp Devices

On 12/17/21 5:15 AM, Raju Rangoju wrote:
> From: Raju Rangoju <Raju.Rangoju@....com>
> 
> Yellow Carp Ethernet devices do not require
> Autonegotiation CDR workaround, hence disable the same.
> 
> Co-developed-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>
> Signed-off-by: Raju Rangoju <Raju.Rangoju@....com>
> ---
>   drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
> index 39e606c4d653..50ffaf30f3c7 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
> @@ -281,6 +281,8 @@ static int xgbe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   		} else if (rdev->device == 0x14b5) {
>   			pdata->xpcs_window_def_reg = PCS_V2_YC_WINDOW_DEF;
>   			pdata->xpcs_window_sel_reg = PCS_V2_YC_WINDOW_SELECT;

Just add a blank line in between here so that the comment stands out a bit 
more.

Thanks,
Tom

> +			/* Yellow Carp devices do not need cdr workaround */
> +			pdata->vdata->an_cdr_workaround = 0;
>   		}
>   	} else {
>   		pdata->xpcs_window_def_reg = PCS_V2_WINDOW_DEF;
> @@ -464,7 +466,7 @@ static int __maybe_unused xgbe_pci_resume(struct device *dev)
>   	return ret;
>   }
>   
> -static const struct xgbe_version_data xgbe_v2a = {
> +static struct xgbe_version_data xgbe_v2a = {
>   	.init_function_ptrs_phy_impl	= xgbe_init_function_ptrs_phy_v2,
>   	.xpcs_access			= XGBE_XPCS_ACCESS_V2,
>   	.mmc_64bit			= 1,
> @@ -479,7 +481,7 @@ static const struct xgbe_version_data xgbe_v2a = {
>   	.an_cdr_workaround		= 1,
>   };
>   
> -static const struct xgbe_version_data xgbe_v2b = {
> +static struct xgbe_version_data xgbe_v2b = {
>   	.init_function_ptrs_phy_impl	= xgbe_init_function_ptrs_phy_v2,
>   	.xpcs_access			= XGBE_XPCS_ACCESS_V2,
>   	.mmc_64bit			= 1,
>