netdev - Re: [PATCH] igc: updated TX timestamp support for non-MSI-X platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mtkzym2o.fsf@intel.com>
Date:   Fri, 17 Dec 2021 13:10:23 -0800
From:   Vinicius Costa Gomes <vinicius.gomes@...el.com>
To:     James McLaughlin <james.mclaughlin@....com>, davem@...emloft.net,
        kuba@...nel.org, jesse.brandeburg@...el.com,
        anthony.l.nguyen@...el.com
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        James McLaughlin <james.mclaughlin@....com>
Subject: Re: [PATCH] igc: updated TX timestamp support for non-MSI-X platforms

Hi James,

James McLaughlin <james.mclaughlin@....com> writes:

> Time synchronization was not properly enabled on non-MSI-X platforms.
>
> Signed-off-by: James McLaughlin <james.mclaughlin@....com>
> Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>

A couple of things that I should have pointed out earlier.

The subject line would be better if it was: "PATCH net" (to indicate
that the patch should be considered for the "net" tree, not "net-next").

Also, it could be made clearer that it's a fix, so the full subject line
could be like this:

      "[PATCH net] igc: Fix TX timestamp support for non-MSI platforms"

Adding a "fixes" tag to the commit message would help, something like this:

       Fixes: 2c344ae24501 ("igc: Add support for TX timestamping")

> ---
>  drivers/net/ethernet/intel/igc/igc_main.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 8e448288ee26..d28a80a00953 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -5467,6 +5467,9 @@ static irqreturn_t igc_intr_msi(int irq, void *data)
>  			mod_timer(&adapter->watchdog_timer, jiffies + 1);
>  	}
>  
> +	if (icr & IGC_ICR_TS)
> +		igc_tsync_interrupt(adapter);
> +
>  	napi_schedule(&q_vector->napi);
>  
>  	return IRQ_HANDLED;
> @@ -5510,6 +5513,9 @@ static irqreturn_t igc_intr(int irq, void *data)
>  			mod_timer(&adapter->watchdog_timer, jiffies + 1);
>  	}
>  
> +	if (icr & IGC_ICR_TS)
> +		igc_tsync_interrupt(adapter);
> +
>  	napi_schedule(&q_vector->napi);
>  
>  	return IRQ_HANDLED;
> -- 
> 2.25.1
>

Cheers,
-- 
Vinicius