netdev - Re: [PATCH net-next 03/13] net: dsa: realtek: rename realtek_smi to realtek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJq09z4NJhU7NgzHNg=jRhi1nZgpszPzCssb_z4h0qYUzcO_FQ@mail.gmail.com>
Date:   Fri, 17 Dec 2021 03:21:39 -0300
From:   Luiz Angelo Daros de Luca <luizluca@...il.com>
To:     Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "arinc.unal@...nc9.com" <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next 03/13] net: dsa: realtek: rename realtek_smi to realtek_priv

Hi Alvin,

Em qui., 16 de dez. de 2021 às 20:22, Alvin Šipraga
<ALSI@...g-olufsen.dk> escreveu:
>
> Hi Luiz,
>
> On 12/16/21 21:13, luizluca@...il.com wrote:
> > From: Luiz Angelo Daros de Luca <luizluca@...il.com>
> >
> > In preparation to adding other interfaces, the private data structure
> > was renamed to priv. Also the only two direct calls from subdrivers
> > to realtek-smi lib were converted into references inside priv.
>
> Maybe split this patch to separate the churn from the more interesting
> change, which I guess is needed to support different bus types for the
> subdrivers.
>

Yes, it is better to split into two commits:

1) net: dsa: realtek: rename realtek_smi to realtek_priv (only string
replace/file move)
2) net: dsa: realtek: remove direct calls to realtek-smi (the good stuff)

And yes, part of the issues you pointed out are just because some
changes landed in the next commit.
As I splitted the commit, I could see a bug in rtl8366rb driver, I
didn't test if priv->setup_interface was set.
It would call a NULL pointer for realtek-mdio interface.