netdev - RE: [PATCH CFT net-next 1/2] net: axienet: convert to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Dec 2021 08:24:11 +0000
From:   Radhey Shyam Pandey <radheys@...inx.com>
To:     Russell King <linux@...linux.org.uk>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Michal Simek <michals@...inx.com>,
        Sean Anderson <sean.anderson@...o.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Harini Katakam <harinik@...inx.com>
Subject: RE: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs

+ Harini

> -----Original Message-----
> From: Russell King <linux@...linux.org.uk>
> Sent: Thursday, December 16, 2021 10:32 PM
> To: Jakub Kicinski <kuba@...nel.org>
> Cc: Michal Simek <michals@...inx.com>; Radhey Shyam Pandey
> <radheys@...inx.com>; Sean Anderson <sean.anderson@...o.com>; David S.
> Miller <davem@...emloft.net>; netdev@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org
> Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs
> 
> On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote:
> > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote:
> > > Convert axienet to use the phylink_pcs layer, resulting in it no
> > > longer being a legacy driver.
> > >
> > > One oddity in this driver is that lp->switch_x_sgmii controls
> > > whether we support switching between SGMII and 1000baseX. However,
> > > when clear, this also blocks updating the 1000baseX advertisement,
> > > which it probably should not be doing. Nevertheless, this behaviour
> > > is preserved but a comment is added.
> > >
> > > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> >
> > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function
> parameter or member 'pcs' not described in 'axienet_local'
> 
> Fixed that and the sha1 issue you raised in patch 2. Since both are
> "documentation" issues, I won't send out replacement patches until I've heard
> they've been tested on hardware though.

Thanks, series looks fine. I have added Harini to this thread and she will
confirm it on hardware.
> 
> Thanks!
> 
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!