netdev - Re: Issues with smsc95xx driver since a049a30fc27c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yb4pTu3FtkGPPpzb@lunn.ch>
Date:   Sat, 18 Dec 2021 19:32:46 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Gabriel Hojda <ghojda@...urs.ro>
Cc:     Martyn Welch <martyn.welch@...labora.com>, netdev@...r.kernel.org,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Markus Reichl <m.reichl@...etechno.de>,
        Steve Glendinning <steve.glendinning@...well.net>,
        UNGLinuxDriver@...rochip.com,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, stable@...nel.org
Subject: Re: Issues with smsc95xx driver since a049a30fc27c

> O.K, stab in the dark. Does the hardware need to be programmed with
> the MAC address? When does this happen? If this is going wrong, it
> could explain the promisc mode. If the MAC address has not been
> programmed, it has no idea what packets are for itself. Put it into
> promisc mode, and it will receive everything, including what it is
> supposed to receive. But looking at the offending patch, it is not
> obvious how it has anything to do with MAC addresses. The only
> unbalanced change in that patch is that smsc95xx_reset(dev) has
> disappeared, not moved to somewhere else.

Ah!

smsc95xx_reset() calls smsc95xx_set_mac_address(). So that fits.
smsc95xx_reset() is also called in smsc95xx_bind(), but maybe that is
not enough?

	Andrew